Open
Conversation
carsonwang
reviewed
Mar 10, 2026
Collaborator
carsonwang
left a comment
carsonwang
left a comment
There was a problem hiding this comment.
It is good idea to add these default options. Could you update some tests to use them? Once this is merged, will be good to have a follow up to cleanup manually added JDK17 options in examples.
| "If used with autoscaling, calculate it from max_workers.", | ||
| file=sys.stderr) | ||
|
|
||
| # On JDK 17+, inject --add-opens flags for driver and app master when |
Collaborator
There was a problem hiding this comment.
can we also cover executor?
| return _cached_java_version | ||
| try: | ||
| out = subprocess.check_output( | ||
| ["java", "-version"], stderr=subprocess.STDOUT, timeout=10 |
Collaborator
There was a problem hiding this comment.
Check JAVA_HOME first?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.